logical_range_filter: Separate a base of ShardExecutor into another class #1343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kou
reviewed
Mar 30, 2022
| @@ -0,0 +1,211 @@ | |||
| module Groonga | |||
| module Sharding | |||
| class ShardExecutorBase | |||
There was a problem hiding this comment.
How about StreamShardExecutor or something?
There was a problem hiding this comment.
Sounds good.
I have renamed it.
HashidaTKS
force-pushed
the
separate_shard_executor
branch
from
e02e083
to
f376b31
Compare
|
I have rebased this branch onto the latest |
|
We can merge this once CI isn't failed. |
|
Would you mind if I merge this? |
|
Merged. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ShardExecutorinto another classShardExecutorBase.ShardExecutorto inheriteShardExecutorBase.This is a preparation for #1341.
ShardExecutorBaserequires children to implementexecute_filteranduse_range_index?.Next step, implementing
execute_filteranduse_range_index?into a class that inheritsShardExecutorBaseinlogical_count.Concern:
Unless already knowing it, a reader of
ShardExecutorBasehas to read the code deeply or actually execute the code to know it.Is there any good way to resolve it in Ruby?
(I also feel that the structure of
ShardExecutorBaseis not so good...)