Skip to content

Commit 9f67c76

Browse files
committed
ma_recovery: unintentional order of operations
Coverity report this as: CID 971840 (#1 of 1): Operands don't affect result (CONSTANT_EXPRESSION_RESULT) result_independent_of_operands: 4 | (flags & 1) is always true regardless of the values of its operands. This occurs as the logical first operand of "?:". The C order of precidence has | over ?:. The indenting implies an | of the 3 terms. Adjust to indented meaning.
1 parent 12ea111 commit 9f67c76

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

storage/maria/ma_recovery.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -888,7 +888,7 @@ prototype_redo_exec_hook(REDO_CREATE_TABLE)
888888
goto end;
889889
fn_format(filename, name, "", MARIA_NAME_IEXT,
890890
(MY_UNPACK_FILENAME |
891-
(flags & HA_DONT_TOUCH_DATA) ? MY_RETURN_REAL_PATH : 0) |
891+
((flags & HA_DONT_TOUCH_DATA) ? MY_RETURN_REAL_PATH : 0)) |
892892
MY_APPEND_EXT);
893893
linkname_ptr= NULL;
894894
create_flag= MY_DELETE_OLD;

0 commit comments

Comments
 (0)