Throw exception instead of returning null when Groovy can't be found (c…

…loses #210)
groovy · Feb 15, 2022 · 20e42db · 20e42db
1 parent 87fd2ca
commit 20e42db
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/src/main/java/org/codehaus/gmavenplus/util/ClassWrangler.java b/src/main/java/org/codehaus/gmavenplus/util/ClassWrangler.java
@@ -116,6 +116,9 @@ public String getGroovyVersionString() {
             if (groovyVersion == null) {
                 log.warn("Unable to get Groovy version from InvokerHelper or GroovySystem, trying jar name.");
                 String jar = getGroovyJar();
+                if (jar == null) {
+                    return null;
+                }
                 int idx = Integer.MAX_VALUE;
                 for (int i = 0; i < 9; i++) {
                     int newIdx = jar.indexOf("-" + i);
@@ -141,8 +144,7 @@ public Version getGroovyVersion() {
         try {
             return Version.parseFromString(getGroovyVersionString());
         } catch (Exception e) {
-            log.error("Unable to determine Groovy version. Is Groovy declared as a dependency?");
-            return null;
+            throw new RuntimeException("Unable to determine Groovy version. Is Groovy declared as a dependency?");
         }
     }
 
@@ -279,8 +281,7 @@ protected String getGroovyJar() {
 
             return groovyJar;
         } catch (ClassNotFoundException e) {
-            log.error("Unable to determine Groovy version. Is Groovy declared as a dependency?");
-            return null;
+            throw new RuntimeException("Unable to determine Groovy version. Is Groovy declared as a dependency?");
         }
     }