Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct version for gemspec/gemfile #63

Merged
merged 2 commits into from
May 29, 2024
Merged

Conversation

seuros
Copy link
Contributor

@seuros seuros commented May 29, 2024

In my previous pr i had a small error due to a rebasing/conflict with upstream.

This PR fixes it.

@grosser
Copy link
Owner

grosser commented May 29, 2024

lmk if you find a for for CI, otherwise I'll take a look

@seuros
Copy link
Contributor Author

seuros commented May 29, 2024

before 5.20
Run options: --seed 7877\n\n# Running:\n\nE\n\nFinished in 0.001204s, 830.5648 runs/s, 0.0000 assertions/s.\n\n 1) Error:\nexplode#test_0001_explodes:\nTypeError: Timeout is not a module\n <internal:[REDACTED]>:38\n <internal:[REDACTED]>:38\n spec/cases/raise.rb:11\n\n1 runs, 0 assertions, 0 failures, 1 errors, 0 skips\n\nFocus on failing tests:\nmtest spec/cases/raise.rb:10

after 5.20
Run options: --seed 7877\n\n# Running:\n\nE\n\nFinished in 0.000983s, 1017.2941 runs/s, 0.0000 assertions/s.\n\n 1) Error:\nexplode#test_0001_explodes:\nTypeError: Timeout is not a module\n lib/maxitest/timeout.rb:9\n lib/maxitest/timeout.rb:4\n <internal:[REDACTED]>:38\n <internal:[REDACTED]>:38\n spec/cases/raise.rb:11\n\n1 runs, 0 assertions, 0 failures, 1 errors, 0 skips\n\nFocus on failing tests:\nmtest spec/cases/raise.rb:10

Output 2: The error traceback additionally includes two entries for lib/maxitest/timeout.rb before the internal Ruby files and the test file.

@grosser
Copy link
Owner

grosser commented May 29, 2024

thx, I'll take another if there is maybe something wrong internally, but this is nice and green anyways :)

@grosser grosser merged commit 6390e5d into grosser:master May 29, 2024
24 checks passed
@grosser
Copy link
Owner

grosser commented May 29, 2024

yeah with pure minitest the backtrace is also longer :/
... lots of diff in that area, seems like an accident to me but also 🤷

@grosser
Copy link
Owner

grosser commented May 29, 2024

5.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants