Skip to content

Conversation

robotrapta
Copy link
Member

Runs server-side (github action).

Copy link
Contributor

@michael-groundlight michael-groundlight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want to use this in all of our python repos, so we should consider creating a custom github action that we can just import: https://docs.github.com/en/actions/creating-actions/about-custom-actions. No need to block on this, but it's worth setting up sometime in the future.

@@ -0,0 +1,28 @@
name: auto-format
Copy link
Contributor

@michael-groundlight michael-groundlight Oct 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In our Makefile, there is a generate target for generating the generated/ code folder from an OpenAPI spec. Let's add black to that target, as it will make the code diffs simpler (versus seeing a big diff, and then seeing it go away in the action). E.g.

generate:
    ...
    poetry run black .

@robotrapta robotrapta merged commit 57c441c into main Oct 25, 2022
@robotrapta robotrapta deleted the autoformat branch October 25, 2022 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants