Skip to content

Conversation

brandon-wada
Copy link
Collaborator

SDK support for resetting detectors

Copy link
Contributor

@timmarkhuff timmarkhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tyler-romero tyler-romero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I really wish we didnt have to skip those tests though. How long does the test_reset_retry test take if you poll every second instead of every minute?

@brandon-wada
Copy link
Collaborator Author

Thanks for the catch Tyler, what I initially thought was a delay was actually a BE bug that Roxanne just fixed. Turned the tests back on

@brandon-wada brandon-wada merged commit 25d646a into main Aug 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants