(0.8.0rc1) Return YES/NO instead of PASS/FAIL #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjvogelsong
commented
Apr 20, 2023
|
Before we release 0.8 I’d like to address the BGR / RGB issue since that’s also a breaking change. |
@robotrapta Good idea. I've created a |
mjvogelsong
changed the title
robotrapta
approved these changes
Apr 25, 2023
| def test_submit_image_query_returns_yes(gl: Groundlight): | ||
| # We use the "never-review" model to guarantee a "yes" answer. | ||
| detector = gl.get_or_create_detector(name="Always a dog", query="Is there a dog?", config_name="never-review") | ||
| image_query = gl.submit_image_query(detector=detector, image="test/assets/dog.jpeg", wait=5) |
There was a problem hiding this comment.
I like this dog. :) https://github.com/groundlight/python-sdk/blob/main/docs/static/img/michonne.jpg
brandon-wada
added a commit
that referenced
this pull request
May 8, 2023
* Bump 0.8.0rc1 * (0.8.0rc1) Return YES/NO instead of PASS/FAIL (#50) * Convert PASS/FAIL to YES/NO * Change to classmethod * Remove logger * Bump 0.8.0 * (0.8.0rc1) Only allow "YES"/"NO" in `add_label()` (#51) * Convert PASS/FAIL to YES/NO * Change to classmethod * Remove logger * Bump 0.8.0 * Only allow YES/NO labels through SDK; Add tests * Add comments * Remove duplicates * Feedback * Add type ignore * Remove select all * Enum * Update pyproject.toml --------- Co-authored-by: Michael Vogelsong <4020875+mjvogelsong@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SDK should not be returning the confusing
PASSorFAILlabels anymore.I'm not a big fan of the mapper in the client, but I think it's an important fix for clarity in the short term.
Fixes #7