Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to prettier2 #44

Merged
merged 1 commit into from
Mar 24, 2020
Merged

upgrade to prettier2 #44

merged 1 commit into from
Mar 24, 2020

Conversation

dbushong
Copy link
Member

  • requires prettier 2.x peer dep
  • marked breaking because of number of style changes
  • chained methods now often on one line
  • arrowParens has old defaults of 'avoid' - we like the old setting
    better for now

See: https://prettier.io/blog/2020/03/21/2.0.0.html

BREAKING CHANGE: requires prettier 2.x peerDep and will result in a
lot of style changes around chained method invocations


This PR was started by: git wf pr

* requires prettier 2.x peer dep
* marked breaking because of number of style changes
* chained methods now often on one line
* arrowParens has old defaults of 'avoid' - we like the old setting
    better for now

See: https://prettier.io/blog/2020/03/21/2.0.0.html

BREAKING CHANGE: requires prettier 2.x peerDep and will result in a
lot of style changes around chained method invocations
Copy link
Member

@aotarola aotarola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💚 💅

@dbushong dbushong merged commit d530190 into master Mar 24, 2020
@dbushong dbushong deleted the dbushong/feature/master/prettier2 branch March 24, 2020 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants