Skip to content
This repository was archived by the owner on Apr 28, 2025. It is now read-only.

fix: The XML source from where we were getting the version changed #38

Conversation

jac1013
Copy link
Contributor

@jac1013 jac1013 commented Apr 12, 2017

Hello Guys,

This fixes #37.

Basically the library was not downloading the latest version, tests weren't aware of this either and that's why they were passing of course.

I would like to get this fix in NPM whenever you can.

Thanks for the library, It's very useful.

@EndangeredMassa
Copy link
Contributor

Ideally we'd have some tests around some of the units in the code, but the high-level tests in place are fine for now. Can you fix the current failing test in CI? Does it fail locally for you as well?

Let me know if you'd like help fixing that test. Thanks for contributing!

@jac1013
Copy link
Contributor Author

jac1013 commented Apr 12, 2017

Sure, let's try to fix it, I'm afraid they are passing locally:

image

Any ideas?

@jac1013
Copy link
Contributor Author

jac1013 commented Apr 12, 2017

Could this be related to Java version in TravisCI, running the command java -jar ~/selenium.jar -h in my machine runs successfully, I assume it's because the latest version of selenium standalone server requires Java 8 (which is the one I have installed), can you confirm this?

@EndangeredMassa EndangeredMassa force-pushed the fix-for-download-of-latest-version-of-selenium branch 2 times, most recently from dbc8127 to 9863512 Compare April 13, 2017 21:44
@EndangeredMassa
Copy link
Contributor

I looked into this a bit. It does seem like a java version issue. Travis says it defaults to 7 right now. I was trying to set it to 8, but having trouble.

I tried installing oracle-java8-installer, but it still fails with the same message. I tried installing openjdk-8-jre, but it fails to find that package even though it's on the whitelist. Do you want to keep looking into this and find the right package or other travis config to make this work?


Travis: Installing Dependencies

@jac1013 jac1013 force-pushed the fix-for-download-of-latest-version-of-selenium branch 4 times, most recently from 4103a29 to 4526207 Compare April 17, 2017 17:42
@jac1013 jac1013 force-pushed the fix-for-download-of-latest-version-of-selenium branch from 4526207 to 2716011 Compare April 17, 2017 17:43
@jac1013
Copy link
Contributor Author

jac1013 commented Apr 17, 2017

Hi @EndangeredMassa I think we are ready to go, I added an addon to travis.yml which let us keep using nodejs as main language and provide us with Java 8 as the default JAVA_HOME in the instance.

Please let me know whenever you publish this in NPM so I can go ahead and change my dependencies in the package.json of the project I'm using this library.

Thanks!

@EndangeredMassa
Copy link
Contributor

Nice work! Thanks a ton for figuring this out!

@EndangeredMassa EndangeredMassa merged commit c895d55 into groupon:master Apr 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

forceUpdate doesn't download latest version
2 participants