Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement pod/SDK version validation #9

Closed
jeremydw opened this issue Mar 6, 2014 · 0 comments
Closed

Implement pod/SDK version validation #9

jeremydw opened this issue Mar 6, 2014 · 0 comments

Comments

@jeremydw
Copy link
Member

jeremydw commented Mar 6, 2014

Currently, grow_version is a required field in podspec.yaml however we don't enforce this requirement. We should:

  • enforce the grow_version (and project_id) keys in podspec.yaml (see documentation),
  • implement a semantic versioning check to ensure that the pod version is compatible with the Grow SDK version.

We currently don't have any centralized location where we validate a pod and its configuration files, so perhaps this would be a good candidate to start that work. Perhaps in a new file pygrow/grow/pods/validation.py.

If the pod fails to validate when the server is started (or when attempting a build/deploy), an error should be shown to the user invoking the command informing them what the issue is and how to fix it.

jeremydw added a commit that referenced this issue Jun 6, 2020
Removed trailing spaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant