Allow GrpcChannel to use WinHttpHandler on Windows Server 2019 #2362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
requested review from
mgravell,
ReubenBond,
BrennanConroy and
amcasey
| // -Client and bidi streaming methods aren't supported. | ||
| // -Windows 11 has full support. | ||
| const int WinServer2022BuildVersion = 20348; | ||
| const int WinServer2019BuildVersion = 17763; |
There was a problem hiding this comment.
Sounds like this is a recent change? Should we be checking the revision version since 17763 will be true for any version of 2019.
There was a problem hiding this comment.
That's true.
I don't know when the change happened. Figuring out this is tough, so I'd like to just allow all of 2019 and then assume that the server is up to date with its patches.
If the feature isn't supported then the client will still error, it just won't get this friendly error.
There was a problem hiding this comment.
If the feature isn't supported then the client will still error, it just won't get this friendly error.
Ah, ok 😃
BrennanConroy
approved these changes
Jan 17, 2024
JamesNK
referenced
this pull request
Jan 18, 2024
oguzhand95
referenced
this pull request
in cerbos/cerbos-sdk-net
Feb 26, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [Google.Protobuf](https://togithub.com/protocolbuffers/protobuf) | `3.25.2` -> `3.25.3` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [Grpc.Net.Client](https://togithub.com/grpc/grpc-dotnet) | `2.60.0` -> `2.61.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [NUnit](https://nunit.org/) ([source](https://togithub.com/nunit/nunit)) | `4.0.1` -> `4.1.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [coverlet.collector](https://togithub.com/coverlet-coverage/coverlet) | `6.0.0` -> `6.0.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>protocolbuffers/protobuf (Google.Protobuf)</summary> ### [`v3.25.3`](https://togithub.com/protocolbuffers/protobuf/compare/v3.25.2...v3.25.3) </details> <details> <summary>grpc/grpc-dotnet (Grpc.Net.Client)</summary> ### [`v2.61.0`](https://togithub.com/grpc/grpc-dotnet/releases/tag/v2.61.0) ##### What's Changed - Update Grpc.Tools to 2.60.0 by [@​JamesNK](https://togithub.com/JamesNK) in [https://github.com/grpc/grpc-dotnet/pull/2336](https://togithub.com/grpc/grpc-dotnet/pull/2336) - Bump dev version to 2.61.0-dev on master branch by [@​stanley-cheung](https://togithub.com/stanley-cheung) in [https://github.com/grpc/grpc-dotnet/pull/2337](https://togithub.com/grpc/grpc-dotnet/pull/2337) - Fix cancellation token reported when using retries by [@​JamesNK](https://togithub.com/JamesNK) in [https://github.com/grpc/grpc-dotnet/pull/2345](https://togithub.com/grpc/grpc-dotnet/pull/2345) - First pass at Grpc.StatusProto API by [@​tonydnewell](https://togithub.com/tonydnewell) in [https://github.com/grpc/grpc-dotnet/pull/2205](https://togithub.com/grpc/grpc-dotnet/pull/2205) - Add ProtoStatus example by [@​JamesNK](https://togithub.com/JamesNK) in [https://github.com/grpc/grpc-dotnet/pull/2273](https://togithub.com/grpc/grpc-dotnet/pull/2273) - Grpc.StatusProto clean up by [@​JamesNK](https://togithub.com/JamesNK) in [https://github.com/grpc/grpc-dotnet/pull/2349](https://togithub.com/grpc/grpc-dotnet/pull/2349) - Bump follow-redirects from 1.15.3 to 1.15.4 in /testassets/InteropTestsGrpcWebWebsite/Tests by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/grpc/grpc-dotnet/pull/2352](https://togithub.com/grpc/grpc-dotnet/pull/2352) - Add key services tests for service and interceptor by [@​JamesNK](https://togithub.com/JamesNK) in [https://github.com/grpc/grpc-dotnet/pull/2356](https://togithub.com/grpc/grpc-dotnet/pull/2356) - Allow GrpcChannel to use WinHttpHandler on Windows Server 2019 by [@​JamesNK](https://togithub.com/JamesNK) in [https://github.com/grpc/grpc-dotnet/pull/2362](https://togithub.com/grpc/grpc-dotnet/pull/2362) - Add .NET 9 NuGet feed by [@​JamesNK](https://togithub.com/JamesNK) in [https://github.com/grpc/grpc-dotnet/pull/2365](https://togithub.com/grpc/grpc-dotnet/pull/2365) - Add missing package mapping for net9 feed by [@​JamesNK](https://togithub.com/JamesNK) in [https://github.com/grpc/grpc-dotnet/pull/2366](https://togithub.com/grpc/grpc-dotnet/pull/2366) - proposal: Build changelog based on previous stable version by [@​tomkerkhove](https://togithub.com/tomkerkhove) in [https://github.com/grpc/grpc-dotnet/pull/2269](https://togithub.com/grpc/grpc-dotnet/pull/2269) - Bump Grpc.Tools to 1.61.0 by [@​apolcyn](https://togithub.com/apolcyn) in [https://github.com/grpc/grpc-dotnet/pull/2370](https://togithub.com/grpc/grpc-dotnet/pull/2370) - Bump versions on v2.61.x by [@​apolcyn](https://togithub.com/apolcyn) in [https://github.com/grpc/grpc-dotnet/pull/2371](https://togithub.com/grpc/grpc-dotnet/pull/2371) - Bump to v2.61.0 on v2.61.x branch by [@​apolcyn](https://togithub.com/apolcyn) in [https://github.com/grpc/grpc-dotnet/pull/2374](https://togithub.com/grpc/grpc-dotnet/pull/2374) ##### New Contributors - [@​tonydnewell](https://togithub.com/tonydnewell) made their first contribution in [https://github.com/grpc/grpc-dotnet/pull/2205](https://togithub.com/grpc/grpc-dotnet/pull/2205) - [@​tomkerkhove](https://togithub.com/tomkerkhove) made their first contribution in [https://github.com/grpc/grpc-dotnet/pull/2269](https://togithub.com/grpc/grpc-dotnet/pull/2269) **Full Changelog**: grpc/grpc-dotnet@v2.60.0...v2.61.0 </details> <details> <summary>nunit/nunit (NUnit)</summary> ### [`v4.1.0`](https://togithub.com/nunit/nunit/releases/tag/4.1.0): NUnit 4.1.0 See [release notes](https://docs.nunit.org/articles/nunit/release-notes/framework.html#nunit-41---february-23-2024) </details> <details> <summary>coverlet-coverage/coverlet (coverlet.collector)</summary> ### [`v6.0.1`](https://togithub.com/coverlet-coverage/coverlet/releases/tag/v6.0.1) ##### Fixed - Uncovered lines in .NET 8 for inheriting records [#​1555](https://togithub.com/coverlet-coverage/coverlet/issues/1555) - Fix record constructors not covered when SkipAutoProps is true [#​1561](https://togithub.com/coverlet-coverage/coverlet/issues/1561) - Fix .NET 7 Method Group branch coverage issue [#​1447](https://togithub.com/coverlet-coverage/coverlet/issues/1447) - Fix ExcludeFromCodeCoverage does not exclude method in a partial class [#​1548](https://togithub.com/coverlet-coverage/coverlet/issues/1548) - Fix ExcludeFromCodeCoverage does not exclude F# task [#​1547](https://togithub.com/coverlet-coverage/coverlet/issues/1547) - Fix issues where ExcludeFromCodeCoverage ignored [#​1431](https://togithub.com/coverlet-coverage/coverlet/issues/1431) - Fix issues with ExcludeFromCodeCoverage attribute [#​1484](https://togithub.com/coverlet-coverage/coverlet/issues/1484) - Fix broken links in documentation [#​1514](https://togithub.com/coverlet-coverage/coverlet/issues/1514) - Fix problem with coverage for .net5 WPF application [#​1221](https://togithub.com/coverlet-coverage/coverlet/issues/1221) by https://github.com/lg2de - Fix unable to instrument module for Microsoft.AspNetCore.Mvc.Razor [#​1459](https://togithub.com/coverlet-coverage/coverlet/issues/1459) by https://github.com/lg2de ##### Improvements - Extended exclude by attribute feature to work with fully qualified name [#​1589](https://togithub.com/coverlet-coverage/coverlet/issues/1589) - Use System.CommandLine instead of McMaster.Extensions.CommandLineUtils [#​1474](https://togithub.com/coverlet-coverage/coverlet/issues/1474) by https://github.com/Bertk - Fix deadlog in Coverlet.Integration.Tests.BaseTest [#​1541](https://togithub.com/coverlet-coverage/coverlet/pull/1541) by https://github.com/Bertk - Add coverlet.msbuild.tasks unit tests [#​1534](https://togithub.com/coverlet-coverage/coverlet/pull/1534) by https://github.com/Bertk [Diff between 6.0.0 and 6.0.1](https://togithub.com/coverlet-coverage/coverlet/compare/v6.0.0...v6.0.1) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/cerbos/cerbos-sdk-net). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xOTEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIxMi4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Oğuzhan Durgun <oguzhandurgun95@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2359