Add WithResolverUserOptions for custom resolver build options #1711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzbarsky
reviewed
Dec 5, 2017
| waitForHandshake bool | ||
| resolverBuilder resolver.Builder | ||
| // Custom user options for resolver.Build. | ||
| resolverBuildUserOptions interface{} |
There was a problem hiding this comment.
nit: maybe buildResolverUserOptions? or userOptionsForBuildResolver?
There was a problem hiding this comment.
resolverBuilderUserOptions?
I'm also OK with this as-is.
There was a problem hiding this comment.
The idea was this is like resolver.Build(UserOptions).
Keeping this as it is now.
|
great, that works for me. thanks! |
dfawley
approved these changes
Dec 5, 2017
| waitForHandshake bool | ||
| resolverBuilder resolver.Builder | ||
| // Custom user options for resolver.Build. | ||
| resolverBuildUserOptions interface{} |
There was a problem hiding this comment.
resolverBuilderUserOptions?
I'm also OK with this as-is.
clientconn.go
Outdated
| @@ -223,6 +225,14 @@ func withResolverBuilder(b resolver.Builder) DialOption { | |||
| } | |||
| } | |||
|
|
|||
| // WithResolverUserOptions returns a DialOptions which sets the UserOptions | |||
menghanl
commented
Dec 6, 2017
| waitForHandshake bool | ||
| resolverBuilder resolver.Builder | ||
| // Custom user options for resolver.Build. | ||
| resolverBuildUserOptions interface{} |
There was a problem hiding this comment.
The idea was this is like resolver.Build(UserOptions).
Keeping this as it is now.
clientconn.go
Outdated
| @@ -223,6 +225,14 @@ func withResolverBuilder(b resolver.Builder) DialOption { | |||
| } | |||
| } | |||
|
|
|||
| // WithResolverUserOptions returns a DialOptions which sets the UserOptions | |||
menghanl
added a commit
to menghanl/grpc-go
that referenced
this pull request
Jan 26, 2018
…grpc#1711)" This reverts commit ff1be3f.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1710