Handle unexpected exceptions on binder threads #10092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All BinderTransport transactions are oneway which means uncaught Exceptions during processing are merely logged locally and not propagated to the peer. Instead, we add a top level catch block that handles the unexpected by shutting down the whole transport. This makes our peer aware of the problem immediately (instead of relying on a deadline) and gives clients a fresh transport instance to handle any retries.
markb74
approved these changes
Apr 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All BinderTransport transactions are oneway which means uncaught Exceptions processing them are merely logged locally and not propagated to the peer. This PR adds a top level catch block that handles the unexpected by shutting down the whole transport. This makes our peer aware of the problem immediately (instead of relying on a deadline) and gives clients a fresh transport instance to handle any retries.