binder: Suppress GuardedBy("this") warning for test access

[kannanjgithub]

No description provided.

[shivaspeaks]

I believe we had an option of making the method synchronized but since this is a test-only method (@VisibleForTesting), we preferred just suppressing it.

Though can we add a comment here saying something like in the added commit?

[ejona86]

Why would we prefer to suppress the warning? If it is test-only then there's no cost to it being synchronized...

If it were a production method it'd have been better to use @GuardedBy("this") to propagate the requirement to the caller. Basically, I don't think we should be in the habit of suppressing synchronization warnings. The only case to suppress is when the checker isn't able to verify something and it is too hard to change it to be verified (e.g., in okhttp some of the lock usage can't be verified by the tool; we'd still love to verify that though).

[ejona86]

Created #12364 to fix the synchronization

[kannanjgithub]

Got it, thanks.