examples: Throw exception in test instead of printStackTrace #6521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Throwing makes cleaner code and also is more helpful if the exception is ever thrown, as the error will be more clear.
| } catch (InterruptedException e) { | ||
| e.printStackTrace(); | ||
| } | ||
| public void tearDown() throws Exception { |
There was a problem hiding this comment.
Couple of points:
-
when Exception does happen, it will fail the test (before it would have passed). I think that's better but making sure that's what you want.
-
throwsis wider than it needs to be (InterruptedException).
There was a problem hiding this comment.
Yes, I want the test to fail. Yes, I purposefully used Exception, since that is pretty normal in tests since most exceptions should just cause the test to fail.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throwing makes cleaner code and also is more helpful if the exception is ever
thrown, as the error will be more clear.
I noticed this after #6512 was already merged. Minor, but good to fix in an example.
CC @dounan