Skip to content

grpclb: expose balancer address related attributes in internal accessor #6669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 1, 2020
Merged

grpclb: expose balancer address related attributes in internal accessor #6669

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e43ae6f
Add getters for grpclb balancer address related attributes.
voidzcy Feb 1, 2020
8085be5
Directly expose constants instead of getters/setters.
voidzcy Feb 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 5 additions & 13 deletions grpclb/src/main/java/io/grpc/grpclb/InternalGrpclbConstantsAccessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,18 +32,10 @@ public class InternalGrpclbConstantsAccessor {
private InternalGrpclbConstantsAccessor() {
}

/**
* Sets attribute for gRPC LB address authority.
*/
public static Attributes setLbAddrAuthorityAttr(
@EquivalentAddressGroup.Attr Attributes attrs, String authority) {
return attrs.toBuilder().set(GrpclbConstants.ATTR_LB_ADDR_AUTHORITY, authority).build();
}
public static Attributes.Key<List<EquivalentAddressGroup>> ATTR_LB_ADDRS =
GrpclbConstants.ATTR_LB_ADDRS;

/**
* Sets attribute for gRPC LB addresses.
*/
public static Attributes setLbAddrAttr(Attributes attrs, List<EquivalentAddressGroup> lbAddrs) {
return attrs.toBuilder().set(GrpclbConstants.ATTR_LB_ADDRS, lbAddrs).build();
}
@EquivalentAddressGroup.Attr
public static Attributes.Key<String> ATTR_LB_ADDR_AUTHORITY =
GrpclbConstants.ATTR_LB_ADDR_AUTHORITY;
}