Skip to content

core: implement Helper#createResolvingOobChannel #6923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2020
Merged

core: implement Helper#createResolvingOobChannel #6923

merged 1 commit into from
Apr 17, 2020

Conversation

creamsoup
Copy link
Contributor

No description provided.

@creamsoup creamsoup requested a review from dapengzhang0 April 14, 2020 00:22
dapengzhang0
dapengzhang0 approved these changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@dapengzhang0 dapengzhang0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@creamsoup creamsoup merged commit 68297d6 into grpc:master Apr 17, 2020
@creamsoup creamsoup deleted the resolving_oob_channel branch April 17, 2020 23:07
dfawley pushed a commit to dfawley/grpc-java that referenced this pull request Jan 15, 2021
@creamsoup @dfawley
core: implement Helper#createResolvingOobChannel (grpc#6923)
3462889
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@dapengzhang0 dapengzhang0 dapengzhang0 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dapengzhang0 dapengzhang0

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@creamsoup @dapengzhang0