Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

okhttp: revert changes for using new APIs to configure TLS in Android #6959

Merged
merged 2 commits into from Apr 21, 2020

Conversation

voidzcy
Copy link
Contributor

@voidzcy voidzcy commented Apr 21, 2020

This reverts commit eb8e314 and commit 5803dfd

Will roll forward after fixing the breakage.

@voidzcy voidzcy requested a review from ericgribkoff Apr 21, 2020
@voidzcy voidzcy merged commit ee8b395 into grpc:master Apr 21, 2020
11 of 13 checks passed
voidzcy added a commit to voidzcy/grpc-java that referenced this issue Apr 21, 2020
voidzcy added a commit that referenced this issue Apr 22, 2020
…#6960)

* Revert "okhttp: revert changes for using new APIs to configure TLS in Android (#6959)"

This reverts commit ee8b395.

Roll forward with adding manual check if hostname contains underscore, as Android's URI implementation allows underscore in hostsname.
dfawley pushed a commit to dfawley/grpc-java that referenced this issue Jan 15, 2021
…grpc#6959)

* Revert "okhttp: Skip enabling SNI and session ticket for fake/test host names (grpc#6949)"

This reverts commit eb8e314.

* Revert "okhttp: use new APIs for configuring TLS whenever possible (Android Q+) (grpc#6912)"

This reverts commit 5803dfd.
dfawley pushed a commit to dfawley/grpc-java that referenced this issue Jan 15, 2021
) (grpc#6960)

* Revert "okhttp: revert changes for using new APIs to configure TLS in Android (grpc#6959)"

This reverts commit ee8b395.

Roll forward with adding manual check if hostname contains underscore, as Android's URI implementation allows underscore in hostsname.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants