grpclb: turn into TRANSIENT_FAILURE if given (by balancer or fallback) an empty list of addresses #7960
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7935
There are two cases gRPCLB needs to handle an empty list of backend addresses:
The remote balancer gives an empty list.
The fallback list given by the resolver, when it is used, turns out to be empty. This is what gRPC-LB without fallback addresses can hang #7935 is describing.
This PR fixes the entire problem. It turns into TRANSIENT_FAILURE as long as the list of backends to be used is found to be empty.
There could be other choices of behaviors such as do not cancel the fallback timer if balancer gives an empty list and only turn into TF if fallback also fail. The choice in this PR is the simplest handling, we don't unnecessarily complicate ourselves.