Skip to content

Conversation

sergiitk
Copy link
Member

Ring hash can only be used from within xds currently, because that's
the only way to get a hash assigned to RPCs which is required for it
to function. So it should be using the _experimental suffix like the
other only-used-from-xds policies.

Fixes #8756

Ring hash can only be used from within xds currently, because that's
the only way to get a hash assigned to RPCs which is required for it
to function. So it should be using the _experimental suffix like the
other only-used-from-xds policies.

Fixes grpc#8756
@sergiitk
Copy link
Member Author

Not sure if we need to rename "ring_hash_lb" to "ring_hash_experimental_lb" in the logger as well:

RingHashLoadBalancer(Helper helper) {
this.helper = checkNotNull(helper, "helper");
syncContext = checkNotNull(helper.getSynchronizationContext(), "syncContext");
logger = XdsLogger.withLogId(InternalLogId.allocate("ring_hash_lb", helper.getAuthority()));
logger.log(XdsLogLevel.INFO, "Created");
}

@sergiitk sergiitk requested a review from ejona86 December 21, 2021 23:13
@sergiitk
Copy link
Member Author

sergiitk commented Jan 5, 2022

@ejona86 friendly ping

@sergiitk sergiitk merged commit 23a2202 into grpc:master Jan 7, 2022
@sergiitk sergiitk deleted the xds-ring-hash-experimental branch January 7, 2022 21:22
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ring hash should be named ring_hash_experimental

2 participants