Skip to content

Conversation

YifeiZhuang
Copy link
Member

@YifeiZhuang YifeiZhuang commented Mar 17, 2023

cc. @temawi

@YifeiZhuang YifeiZhuang changed the title add command buildscript: iterate example folder and build Mar 17, 2023
@YifeiZhuang
Copy link
Member Author

It seems revealing failure on example-servlet that was not covered by the current build.

+ pushd examples/example-servlet
+ ../gradlew build -PtargetArch=x86_64 -Pcheckstyle.ignoreFailures=false -PfailOnWarnings=true -PerrorProne=true -PskipAndroid=true -Dorg.gradle.parallel=true
/grpc-java
/grpc-java/examples/example-servlet /grpc-java

FAILURE: Build failed with an exception.

* Where:
Build file '/grpc-java/examples/example-servlet/build.gradle' line: 26

* What went wrong:
A problem occurred evaluating root project 'example-servlet'.
> Could not find method providedImplementation() for arguments [javax.servlet:javax.servlet-api:4.0.1, org.apache.tomcat:annotations-api:6.0.53] on object of type org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler.

@YifeiZhuang YifeiZhuang merged commit c1ff4a8 into grpc:master Mar 17, 2023
larry-safran pushed a commit to larry-safran/grpc-java that referenced this pull request Mar 20, 2023
larry-safran pushed a commit to larry-safran/grpc-java that referenced this pull request Mar 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2023
@YifeiZhuang YifeiZhuang deleted the iterate-example branch January 9, 2024 19:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants