Skip to content

Conversation

ejona86
Copy link
Member

@ejona86 ejona86 commented Mar 17, 2023

It uses the echo service for both unary and bidi RPCs, to show the various cancellation circumstances and APIs.


I'm not wild about all the comments needed, as it reduces the "flow" when reading, but it seemed they were needed. Maybe I could remove the "Make logs more obvious" comments, but...

@ejona86 ejona86 requested a review from YifeiZhuang March 17, 2023 23:26
Copy link
Member

@YifeiZhuang YifeiZhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📖

ejona86 added 2 commits March 21, 2023 12:02
It uses the echo service for both unary and bidi RPCs, to show the
various cancellation circumstances and APIs.
@ejona86 ejona86 force-pushed the example-cancellation branch from 0b507da to fe2f287 Compare March 21, 2023 19:03
@YifeiZhuang
Copy link
Member

oh Larry is fixing the bazel build in #9969

@ejona86 ejona86 merged commit 39c9ebf into grpc:master Mar 23, 2023
@ejona86 ejona86 deleted the example-cancellation branch March 23, 2023 01:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants