gcp-o11y: add default custom tag for metrics exporter #9982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejona86
added
the
TODO:release blocker
ejona86
approved these changes
Mar 22, 2023
ejona86
added
TODO:backport
ejona86
removed
the
TODO:backport
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a default custom tag for metrics, irrespective of custom tags being present in the observability configuration.
OpenCensus by default adds a custom tag opencenus_task for metrics which gets overriden if custom tags are set.
The unique custom tag is required to ensure the uniqueness of the Timeseries. The format of the default custom tag is:
java-{PID}@{HOSTNAME}, if{PID}is not available a random number will be used.