Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ResponseType to ServerWritableStream #1590

Merged
merged 1 commit into from Oct 5, 2020

Conversation

@badsyntax
Copy link
Contributor

@badsyntax badsyntax commented Sep 25, 2020

To provide better type compatibility with @grpc/grpc-js.

See #1581

Here's the @grpc/grpc-js type definition for ServerWritableStream:

export type ServerWritableStream<
RequestType,
ResponseType
> = ServerSurfaceCall &

To provide better type compatibility with @grpc/grpc-js
@badsyntax badsyntax marked this pull request as ready for review Sep 25, 2020
@murgatroid99 murgatroid99 merged commit 96803d4 into grpc:grpc@1.24.x Oct 5, 2020
230 of 270 checks passed
@badsyntax
Copy link
Contributor Author

@badsyntax badsyntax commented Oct 18, 2020

@murgatroid99 any chance this fix can be released as a new patch version for grpc@1.24.x?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants