Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpc-js: End calls faster if the deadline has already passed #1648

Merged
merged 1 commit into from
Jan 7, 2021
Merged

grpc-js: End calls faster if the deadline has already passed #1648

merged 1 commit into from
Jan 7, 2021

Conversation

murgatroid99
Copy link
Member

This should fix #1636.

process.nextTick queues a function to be called in the current phase of the event loop, while setTimeout will wait until the timer handling phase. We still want to call cancelWithStatus asynchronously for consistency.

@eyalpost
Copy link

Hi
Any chance this will be merged soon?

@murgatroid99 murgatroid99 merged commit 0b026be into grpc:@grpc/grpc-js@1.2.x Jan 7, 2021
@murgatroid99 murgatroid99 mentioned this pull request Jan 26, 2021
Closed
@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasnoble nicolasnoble nicolasnoble approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@murgatroid99 @eyalpost @nicolasnoble