grpc-js: delays maybeOutputStatus in end event handler a bit #2315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix some edge cases that the process.nextTick in push function hasn't been processed yet while the end stream event kicks in, which updates statusOutput causing the last chunk of data desserted.
|
|
|
I see the issue but I don't think this is the right way to fix it. |
|
The change I made in the PR I linked has been published in version 1.8.2. That change supersedes this one so I'm closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some edge cases that the process.nextTick in
pushfunction hasn't been processed yet while the end stream event kicks in, which updatesstatusOutputcausing the last chunk of data desserted.