Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add return type definition to watchConnectivityState #496

Merged
merged 1 commit into from
Aug 14, 2018

Conversation

kjin
Copy link
Contributor

@kjin kjin commented Aug 14, 2018

No description provided.

@kjin kjin requested a review from murgatroid99 August 14, 2018 17:00
@murgatroid99
Copy link
Member

This should probably be in the 1.14 branch to get it out quickly.

@kjin kjin changed the base branch from master to grpc@1.14.x August 14, 2018 17:28
@kjin kjin changed the base branch from grpc@1.14.x to master August 14, 2018 17:29
@kjin kjin changed the base branch from master to grpc@1.14.x August 14, 2018 17:30
@kjin
Copy link
Contributor Author

kjin commented Aug 14, 2018

@murgatroid99 OK, changed the target.

@kjin
Copy link
Contributor Author

kjin commented Aug 14, 2018

Whoops, didn't see that #494 was already opened.

@andrew8er I'd be willing to close this PR in favor of yours, but can you re-target your PR to land on grpc@1.14.x?

@murgatroid99 murgatroid99 merged commit d8287bf into grpc:grpc@1.14.x Aug 14, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Nov 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants