Skip to content

Conversation

glbrntt
Copy link
Collaborator

@glbrntt glbrntt commented Dec 20, 2024

Motivation:

The reflection service is widely used and we should offer an implementation out-of-the-box.

Modifications:

  • Add back an updated version of the reflection service from grpc-swift v1.

Result:

Can use reflection service

@glbrntt glbrntt added the 🆕 semver/minor Adds new public API. label Dec 20, 2024
Motivation:

The reflection service is widely used and we should offer an
implementation out-of-the-box.

Modifications:

- Add back an updated version of the reflection service from grpc-swift v1.

Result:

Can use reflection service
@glbrntt glbrntt linked an issue Dec 20, 2024 that may be closed by this pull request
@glbrntt glbrntt marked this pull request as ready for review December 20, 2024 13:03
@glbrntt glbrntt requested a review from gjcairo December 20, 2024 13:03
Copy link
Collaborator

@gjcairo gjcairo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only a couple of nits - thanks George!

Co-authored-by: Gus Cairo <me@gustavocairo.com>
@glbrntt glbrntt merged commit 0c41ffe into grpc:main Dec 20, 2024
20 of 21 checks passed
@glbrntt glbrntt deleted the reflection branch December 20, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🆕 semver/minor Adds new public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reflection service messages are public API
2 participants