Bring HealthService API in line with ReflectionService #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The reflection service is a single type called `ReflectionService`. The Health service is a single type (called `Health`) holding an instance of the `HealthService` and a type to provide values to the service. This indirection isn't necessary, the health service can just hold it instead. This makes the API more like the reflection service and removes indirection. Modifications: - Remove indirection from health service and rename from 'Health' to 'HealthService'. - Make the reflection service a struct (it was a class for no good reason). Result: More consistent API
gjcairo
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The reflection service is a single type called
ReflectionService. TheHealth service is a single type (called
Health) holding an instance ofthe
HealthServiceand a type to provide values to the service. Thisindirection isn't necessary, the health service can just hold it
instead. This makes the API more like the reflection service and removes
indirection.
Modifications:
'HealthService'.
reason).
Result:
More consistent API