Adopt swift-testing for status tests #2049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swift-testing has a number of advantages over XCTest (parameterisation, organisation, failure messages etc.), we should start using it instead of XCTest. Modifications: - Convert the Status tests - Add a dependency on swift-testing on Linux (this can be removed when it's included as part of the toolchain) - Fixed a couple of bugs found by additional testing Results: Better tests
gjcairo
approved these changes
Sep 9, 2024
| XCTAssertNil(Status.Code(rawValue: -1)) | ||
| XCTAssertNil(Status.Code(rawValue: 1000)) | ||
| XCTAssertNil(Status.Code(rawValue: .max)) | ||
| @Test("Initialize from invalid rawValue", arguments: [-1, 17, 100, .max]) |
There was a problem hiding this comment.
I'm not sure it's really important, but we're not testing for all values from 17 to UInt8.max anymore
There was a problem hiding this comment.
Yeah, not sure it really matters tbh. The UInt8 is an implementation detail so a bit odd to do all of those values given the parameter is an Int.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
swift-testing has a number of advantages over XCTest (parameterisation, organisation, failure messages etc.), we should start using it instead of XCTest.
Modifications:
Results:
Better tests