Skip to content

Conversation

glbrntt
Copy link
Collaborator

@glbrntt glbrntt commented Sep 9, 2024

Motivation:

swift-testing has a number of advantages over XCTest (parameterisation, organisation, failure messages etc.), we should start using it instead of XCTest.

Modifications:

  • Convert the Metadata tests

Results:

Better tests

Motivation:

swift-testing has a number of advantages over XCTest (parameterisation,
organisation, failure messages etc.), we should start using it instead
of XCTest.

Modifications:

- Convert the Metadata tests

Results:

Better tests
@glbrntt glbrntt added the version/v2 Relates to v2 label Sep 9, 2024
@glbrntt glbrntt requested a review from gjcairo September 9, 2024 15:55
Copy link
Collaborator

@gjcairo gjcairo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@glbrntt glbrntt enabled auto-merge (squash) September 9, 2024 16:04
@glbrntt glbrntt merged commit 40f316e into grpc:main Sep 9, 2024
15 of 17 checks passed
@glbrntt glbrntt deleted the v2/swift-testing-metadata-tests branch September 9, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

version/v2 Relates to v2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants