Skip to content

Conversation

gjcairo
Copy link
Collaborator

@gjcairo gjcairo commented Sep 11, 2024

This PR adds a NIOTransportServices H2 client transport to gRPC v2.

@gjcairo gjcairo added the version/v2 Relates to v2 label Sep 11, 2024
@gjcairo gjcairo requested a review from glbrntt September 11, 2024 09:46
Copy link
Collaborator

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks really good! There one additional thing we should do in this PR though which is allowing the HTTP2TransportTests to use the NIOTS client transport.

Copy link
Collaborator

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you Gus!

@gjcairo gjcairo enabled auto-merge (squash) September 11, 2024 14:33
@gjcairo gjcairo merged commit b036fb7 into grpc:main Sep 11, 2024
14 of 17 checks passed
@gjcairo gjcairo deleted the niots-client branch September 11, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

version/v2 Relates to v2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants