Skip to content

Conversation

glbrntt
Copy link
Collaborator

@glbrntt glbrntt commented Sep 20, 2024

Motivation:

v2 will be split across a number of packages, and v1 will be maintained on the 'release/1.x' branch. In order to do the package split this package needs to be whittled down to only the v2 components which will remain within this package.

Modifications:

  • Remove v1 code
  • Remove v2 code destined for other packages
  • Reshuffle a few scripts

Result:

  • Package contains only the intended code

Motivation:

v2 will be split across a number of packages, and v1 will be maintained
on the 'release/1.x' branch. In order to do the package split this
package needs to be whittled down to only the v2 components which will
remain within this package.

Modifications:

- Remove v1 code
- Remove v2 code destined for other packages
- Reshuffle a few scripts

Result:

- Package contains only the intended code
@glbrntt glbrntt marked this pull request as ready for review September 20, 2024 14:17
@glbrntt glbrntt added the version/v2 Relates to v2 label Sep 20, 2024
Copy link
Collaborator

@FranzBusch FranzBusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked at each line and LGTM! Happy Friday :)

@glbrntt glbrntt merged commit 9bdb0d1 into grpc:main Sep 20, 2024
4 of 6 checks passed
@glbrntt glbrntt deleted the v2/package-to-v2 branch September 20, 2024 14:19
@rnro rnro mentioned this pull request Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

version/v2 Relates to v2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants