Do not build with boringssl ASM when using system openssl #24449
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
gnossen
added
area/build
kind/bug
kokoro:run
lang/Python
release notes: no
|
CC @lidizheng to get one other pair of eyes on this before merge. |
5 tasks
aweits
added a commit
to aweits/spack
that referenced
this pull request
Nov 3, 2020
aweits
added a commit
to spack/spack
that referenced
this pull request
Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit 35c0a4c setup.py was changed to allow build of grpcio to use asm files for boringssl but it fails to take into account the case when we are not using boringssl at all and building with
GRPC_PYTHON_BUILD_SYSTEM_OPENSSL=1is now failing for this reason.@donnadionne