Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn loading system root certificate as default #16536

Merged
merged 1 commit into from
Sep 5, 2018
Merged

Turn loading system root certificate as default #16536

merged 1 commit into from
Sep 5, 2018

Conversation

jiangtaoli2016
Copy link

This is followup of #16083. If there is large performance regression, we can revert this back.

@jiangtaoli2016 jiangtaoli2016 self-assigned this Aug 31, 2018
@jiangtaoli2016 jiangtaoli2016 added the release notes: no Indicates if PR should not be in release notes label Aug 31, 2018
@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE                                                                      FILE SIZE
 ++++++++++++++ GROWING                                                        ++++++++++++++

 -------------- SHRINKING                                                      --------------
  -0.0%     -56 [None]                                                            -216  -0.0%
  -0.8%     -80 src/core/lib/security/security_connector/security_connector.cc     -80  -0.8%
     -13.2%     -80 grpc_core::DefaultSslRootStore::ComputePemRootCerts                -80 -13.2%

  -0.0%    -136 TOTAL                                                             -296  -0.0%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link 

[trickle] No significant performance differences

@grpc-testing
Copy link 

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,954,820      Total (<)      1,955,002

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,843,750      Total (<)     10,843,759

 No significant differences in binary sizes

@grpc-testing
Copy link 

[microbenchmarks] No significant performance differences

@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE                                                                      FILE SIZE
 ++++++++++++++ GROWING                                                        ++++++++++++++

 -------------- SHRINKING                                                      --------------
  -0.0%     -56 [None]                                                            -216  -0.0%
  -0.8%     -80 src/core/lib/security/security_connector/security_connector.cc     -80  -0.8%
     -13.2%     -80 grpc_core::DefaultSslRootStore::ComputePemRootCerts                -80 -13.2%

  -0.0%    -136 TOTAL                                                             -296  -0.0%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link 

[trickle] No significant performance differences

@grpc-testing
Copy link 

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,954,820      Total (<)      1,955,002

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,843,755      Total (<)     10,843,759

 No significant differences in binary sizes

@grpc-testing
Copy link 

[microbenchmarks] No significant performance differences

@jiangtaoli2016
Copy link
Author

@ZhouyihaiDing PTAL

@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE                                                                      FILE SIZE
 ++++++++++++++ GROWING                                                        ++++++++++++++
  [ = ]       0 [None]                                                             +48  +0.0%

 -------------- SHRINKING                                                      --------------
  -0.3%     -32 src/core/lib/security/security_connector/security_connector.cc     -32  -0.3%
      -6.6%     -40 grpc_core::DefaultSslRootStore::ComputePemRootCerts                -40  -6.6%

  -0.0%     -32 TOTAL                                                              +16  +0.0%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link 

[trickle] No significant performance differences

ZhouyihaiDing
ZhouyihaiDing approved these changes Sep 1, 2018
View reviewed changes
Copy link
Contributor

@ZhouyihaiDing ZhouyihaiDing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!
Please merge until all tests have passed.

@grpc-testing
Copy link 

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,955,006      Total (>)      1,955,002

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,843,753      Total (<)     10,843,756

 No significant differences in binary sizes

@grpc-testing
Copy link 

[microbenchmarks] No significant performance differences

@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE                                                                      FILE SIZE
 ++++++++++++++ GROWING                                                        ++++++++++++++
  [ = ]       0 [None]                                                             +48  +0.0%

 -------------- SHRINKING                                                      --------------
  -0.3%     -32 src/core/lib/security/security_connector/security_connector.cc     -32  -0.3%
      -6.6%     -40 grpc_core::DefaultSslRootStore::ComputePemRootCerts                -40  -6.6%

  -0.0%     -32 TOTAL                                                              +16  +0.0%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link 

[trickle] No significant performance differences

@grpc-testing
Copy link 

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,955,006      Total (>)      1,955,002

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,843,751      Total (<)     10,843,756

 No significant differences in binary sizes

@grpc-testing
Copy link 

[microbenchmarks] No significant performance differences

@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE                                                                      FILE SIZE
 ++++++++++++++ GROWING                                                        ++++++++++++++
  [ = ]       0 [None]                                                             +40  +0.0%

 -------------- SHRINKING                                                      --------------
  -0.3%     -32 src/core/lib/security/security_connector/security_connector.cc     -32  -0.3%
      -6.6%     -40 grpc_core::DefaultSslRootStore::ComputePemRootCerts                -40  -6.6%

  -0.0%     -32 TOTAL                                                               +8  +0.0%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link 

[trickle] No significant performance differences

@grpc-testing
Copy link 

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,955,960      Total (>)      1,955,956

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,843,884      Total (<)     10,843,887

 No significant differences in binary sizes

@grpc-testing
Copy link 

[microbenchmarks] No significant performance differences

@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE                                                                      FILE SIZE
 ++++++++++++++ GROWING                                                        ++++++++++++++
  [ = ]       0 [None]                                                             +40  +0.0%

 -------------- SHRINKING                                                      --------------
  -0.3%     -32 src/core/lib/security/security_connector/security_connector.cc     -32  -0.3%
      -6.6%     -40 grpc_core::DefaultSslRootStore::ComputePemRootCerts                -40  -6.6%

  -0.0%     -32 TOTAL                                                               +8  +0.0%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link 

[trickle] No significant performance differences

@grpc-testing
Copy link 

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,955,960      Total (>)      1,955,956

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,843,887      Total (<)     10,843,892

 No significant differences in binary sizes

@grpc-testing
Copy link 

[microbenchmarks] No significant performance differences

@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE                                                                      FILE SIZE
 ++++++++++++++ GROWING                                                        ++++++++++++++
  [ = ]       0 [None]                                                             +40  +0.0%

 -------------- SHRINKING                                                      --------------
  -0.3%     -32 src/core/lib/security/security_connector/security_connector.cc     -32  -0.3%
      -6.6%     -40 grpc_core::DefaultSslRootStore::ComputePemRootCerts                -40  -6.6%

  -0.0%     -32 TOTAL                                                               +8  +0.0%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link 

[trickle] No significant performance differences

@grpc-testing
Copy link 

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,955,960      Total (>)      1,955,956

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,843,884      Total (<)     10,843,889

 No significant differences in binary sizes

@grpc-testing
Copy link 

[microbenchmarks] No significant performance differences

@jiangtaoli2016
Copy link
Author

#16471

@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE                                                                      FILE SIZE
 ++++++++++++++ GROWING                                                        ++++++++++++++
  [ = ]       0 [None]                                                             +40  +0.0%

 -------------- SHRINKING                                                      --------------
  -0.3%     -32 src/core/lib/security/security_connector/security_connector.cc     -32  -0.3%
      -6.6%     -40 grpc_core::DefaultSslRootStore::ComputePemRootCerts                -40  -6.6%

  -0.0%     -32 TOTAL                                                               +8  +0.0%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link 

[trickle] No significant performance differences

@grpc-testing
Copy link 

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,955,960      Total (>)      1,955,956

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,843,885      Total (<)     10,843,887

 No significant differences in binary sizes

@grpc-testing
Copy link 

[microbenchmarks] No significant performance differences

@jiangtaoli2016
Copy link
Author

Two failing tests seem unrelated to this PR. Let me merge.

@jiangtaoli2016 jiangtaoli2016 merged commit 23afefe into grpc:master Sep 5, 2018
@jiangtaoli2016 jiangtaoli2016 added release notes: yes Indicates if PR needs to be in release notes and removed release notes: no Indicates if PR should not be in release notes labels Sep 5, 2018
@dependencies dependencies bot mentioned this pull request Oct 25, 2018
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Jan 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ZhouyihaiDing ZhouyihaiDing ZhouyihaiDing approved these changes

Assignees

@jiangtaoli2016 jiangtaoli2016

Labels
lang/core release notes: yes Indicates if PR needs to be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jiangtaoli2016 @grpc-testing @ZhouyihaiDing @kokoro-team @srini100