Preparation for the new background poller 'epollbg' #17244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and get rid of the dependency loop on the grpc shutdown path. Make sure all background closures are complete before shutting down the other grpc modules. Avoid using the backup poller in TCP endpoints if using the background poller.
guantaol
added
lang/core
release notes: yes
|
|
|
|
|
The test failures are because we forget to update iomgr_windows.cc etc. Add the missing changes now. |
|
|
|
|
|
|
|
|
vjpai
suggested changes
Nov 26, 2018
| GRPC_CLOSURE_INIT(&tcp->write_done_closure, | ||
| tcp_drop_uncovered_then_handle_write, tcp, | ||
| grpc_schedule_on_exec_ctx); | ||
| if (grpc_event_engine_run_in_background()) { |
There was a problem hiding this comment.
Since this will be constant once the code has started, can this information be memoized rather than having to continuously call a virtual function?
There was a problem hiding this comment.
In retrospect, I think my comment here was misguided because this isn't an actual virtual function after all. It lives in the vtbl but is just a boolean, and I hadn't noticed that at first.
There was a problem hiding this comment.
So I think it should be fine to call grpc_event_engine_run_in_background() in the if condition, right? Given that grpc_event_engine_run_in_background() only accesses a boolean member of a global struct, it should not be very costly.
There was a problem hiding this comment.
Done. Revert the last two commits.
…s in background or not
|
vjpai
suggested changes
Nov 26, 2018
src/core/lib/iomgr/tcp_posix.cc
Outdated
|
|
||
| static bool event_engine_run_in_background = | ||
| grpc_event_engine_run_in_background(); | ||
| if (event_engine_run_in_background) { |
There was a problem hiding this comment.
I think this is going to compile down to a lock / call / unlock . Can this memoization be done in the plugin initialization instead?
vjpai
suggested changes
Nov 26, 2018
|
|
|
This reverts commit c1af11f.
…gine runs in background or not" This reverts commit 9bbda89.
|
|
vjpai
approved these changes
Nov 27, 2018
|
|
|
|
|
|
|
New flaky test: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend ev_posix.* to prepare for the new background poller 'epollbg',
and get rid of the dependency loop on the grpc shutdown path. Make sure
all background closures are complete before shutting down the other grpc
modules.
Avoid using the backup poller in TCP endpoints if using the background
poller.