Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use x64 tools on 64-bit Windows in Grpc.Tools (#17437 for master branch) #17524

Merged
merged 1 commit into from
Dec 18, 2018

Conversation

jtattermusch
Copy link
Contributor

The Windows Nano Server Docker image does not support 32-bit executables.

See: https://docs.microsoft.com/windows-server/get-started/getting-started-with-nano-server#important-differences-in-nano-server
See: #13207 (comment)
Close: #13098 (wontfix)

Copy link
Contributor Author

@jtattermusch jtattermusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@grpc-testing
Copy link

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,026,842      Total (=)      2,026,842

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,324,726      Total (<)     11,324,728

 No significant differences in binary sizes


@kkm000
Copy link
Contributor

kkm000 commented Dec 18, 2018

@jtattermusch, Thanks! So I'll close the other one?

@jtattermusch
Copy link
Contributor Author

Known failures:
#17526

@jtattermusch jtattermusch merged commit 70a4915 into grpc:master Dec 18, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Mar 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lang/C# release notes: yes Indicates if PR needs to be in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No need to package 64-bit protoc and C# codegen for Windows
5 participants