Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C#: add SkipGrpcNativeLibs flag (in Grpc.Core.targets) #22894

Merged
merged 4 commits into from
May 12, 2020
Merged

C#: add SkipGrpcNativeLibs flag (in Grpc.Core.targets) #22894

merged 4 commits into from
May 12, 2020

Conversation

vivainio
Copy link
Contributor

@vivainio vivainio commented May 7, 2020

Implement SkipGrpcNativeLibsCopying in Grpc.Core.targets file, to fix #21867

@linux-foundation-easycla
Copy link

CLA Check

@vivainio vivainio mentioned this pull request May 7, 2020
Closed
@jtattermusch jtattermusch self-assigned this May 8, 2020
@jtattermusch jtattermusch self-requested a review May 8, 2020 13:03
@jtattermusch
Copy link
Contributor

@vivainio note that you need to sign CLA first, otherwise we can't accept.

@jtattermusch jtattermusch added kokoro:run release notes: yes Indicates if PR needs to be in release notes labels May 11, 2020
@jtattermusch jtattermusch changed the title C#: SkipGrpcNativeLibsCopying flag C#: add SkipGrpcNativeLibs flag (in Grpc.Core.targets) May 11, 2020
@jtattermusch
Copy link
Contributor

jtattermusch commented May 11, 2020 •
edited
Loading

Adhoc artifact build: sponge/31cdfe12-30ad-42e9-a66f-8b320b152d42 (will post results later).

Update:
Distribtests are green https://source.cloud.google.com/results/invocations/cbef6038-4c3d-4135-9068-cf0356f0450a

jtattermusch
jtattermusch approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@jtattermusch jtattermusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the tests are green

@jtattermusch jtattermusch merged commit cce83b9 into grpc:master May 12, 2020
@halachkin halachkin mentioned this pull request Sep 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apolcyn apolcyn apolcyn approved these changes

@jtattermusch jtattermusch jtattermusch approved these changes

Assignees

@jtattermusch jtattermusch

Labels
lang/C# release notes: yes Indicates if PR needs to be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

C#: Grpc.Core native libs copying blocked by IIS locking the files
4 participants
@vivainio @jtattermusch @apolcyn @grpc-kokoro