-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update third_party/protobuf to 3.21.12 #32136
Update third_party/protobuf to 3.21.12 #32136
Conversation
Python311 artifact build on windows failure is interesting: |
b239f5f
to
f5eeb59
Compare
The sanity test error seem to be due to a design flaw in
|
…ept new-style protobuf tags
And it might have been a one-off flake. |
CC @sampajano for the |
Thanks for cc! I'm not very familiar with protobuf versioning but i suppose this "3.x.y" format won't work forever.. hence i've added a comment for you to link to the source of why you're making this change so we can update it in the future when appropriate. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the change! iOS related change LGTM thanks!
* Update third_party/protobuf * run tools/distrib/python/make_grpcio_tools.py * update build_handwritten.yaml * regenerate projects * manual change: fix tools/distrib/check_protobuf_pod_version.sh to accept new-style protobuf tags * improve comments for check_protobuf_pod_version hack
* Update third_party/protobuf * run tools/distrib/python/make_grpcio_tools.py * update build_handwritten.yaml * regenerate projects * manual change: fix tools/distrib/check_protobuf_pod_version.sh to accept new-style protobuf tags * improve comments for check_protobuf_pod_version hack
Change was created by the release automation script. See go/grpc-release