-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PSM interop] Don't fail target if sub-target already failed #33222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuanWang-Amos
added
release notes: no
Indicates if PR should not be in release notes
area/psm interop
labels
May 23, 2023
grpc-checks
bot
added
per-call-memory/neutral
per-channel-memory/neutral
bloat/none
labels
May 23, 2023
sergiitk
changed the title
[xds interop] don't fail target if sub-target already failed
[PSM interop] Don't fail target if sub-target already failed
May 30, 2023
sergiitk
approved these changes
May 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gnossen
approved these changes
May 31, 2023
XuanWang-Amos
added a commit
that referenced
this pull request
May 31, 2023
We configured TestGrid to file bug separately for each failed sub-target, if we still fail the main target, TestGrid will fail duplicate bugs.
XuanWang-Amos
added a commit
that referenced
this pull request
May 31, 2023
We configured TestGrid to file bug separately for each failed sub-target, if we still fail the main target, TestGrid will fail duplicate bugs.
XuanWang-Amos
added a commit
that referenced
this pull request
May 31, 2023
We configured TestGrid to file bug separately for each failed sub-target, if we still fail the main target, TestGrid will fail duplicate bugs.
XuanWang-Amos
added a commit
that referenced
this pull request
May 31, 2023
We configured TestGrid to file bug separately for each failed sub-target, if we still fail the main target, TestGrid will fail duplicate bugs.
XuanWang-Amos
added a commit
that referenced
this pull request
May 31, 2023
We configured TestGrid to file bug separately for each failed sub-target, if we still fail the main target, TestGrid will fail duplicate bugs.
XuanWang-Amos
added a commit
that referenced
this pull request
May 31, 2023
We configured TestGrid to file bug separately for each failed sub-target, if we still fail the main target, TestGrid will fail duplicate bugs.
XuanWang-Amos
added a commit
that referenced
this pull request
May 31, 2023
We configured TestGrid to file bug separately for each failed sub-target, if we still fail the main target, TestGrid will fail duplicate bugs.
XuanWang-Amos
added a commit
that referenced
this pull request
May 31, 2023
We configured TestGrid to file bug separately for each failed sub-target, if we still fail the main target, TestGrid will fail duplicate bugs.
XuanWang-Amos
added a commit
that referenced
this pull request
May 31, 2023
We configured TestGrid to file bug separately for each failed sub-target, if we still fail the main target, TestGrid will fail duplicate bugs.
XuanWang-Amos
added a commit
that referenced
this pull request
May 31, 2023
We configured TestGrid to file bug separately for each failed sub-target, if we still fail the main target, TestGrid will fail duplicate bugs.
sergiitk
pushed a commit
that referenced
this pull request
May 31, 2023
…#33303) We configured TestGrid to file bug separately for each failed sub-target, if we still fail the main target, TestGrid will fail duplicate bugs. <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->
copybara-service
bot
added
the
imported
Specifies if the PR has been imported to the internal repository
label
May 31, 2023
XuanWang-Amos
added a commit
to XuanWang-Amos/grpc
that referenced
this pull request
Jun 22, 2023
…rpc#33520) Follow up change of grpc#33222. We don't want file multiple bugs if any of the sub-tests of the `url_map` test fails.
XuanWang-Amos
added a commit
to XuanWang-Amos/grpc
that referenced
this pull request
Jun 22, 2023
…rpc#33520) Follow up change of grpc#33222. We don't want file multiple bugs if any of the sub-tests of the `url_map` test fails.
XuanWang-Amos
added a commit
to XuanWang-Amos/grpc
that referenced
this pull request
Jun 22, 2023
…rpc#33520) Follow up change of grpc#33222. We don't want file multiple bugs if any of the sub-tests of the `url_map` test fails.
XuanWang-Amos
added a commit
to XuanWang-Amos/grpc
that referenced
this pull request
Jun 22, 2023
…rpc#33520) Follow up change of grpc#33222. We don't want file multiple bugs if any of the sub-tests of the `url_map` test fails.
XuanWang-Amos
added a commit
to XuanWang-Amos/grpc
that referenced
this pull request
Jun 22, 2023
…rpc#33520) Follow up change of grpc#33222. We don't want file multiple bugs if any of the sub-tests of the `url_map` test fails.
XuanWang-Amos
added a commit
to XuanWang-Amos/grpc
that referenced
this pull request
Jun 22, 2023
…rpc#33520) Follow up change of grpc#33222. We don't want file multiple bugs if any of the sub-tests of the `url_map` test fails.
XuanWang-Amos
added a commit
to XuanWang-Amos/grpc
that referenced
this pull request
Jun 22, 2023
…rpc#33520) Follow up change of grpc#33222. We don't want file multiple bugs if any of the sub-tests of the `url_map` test fails.
XuanWang-Amos
added a commit
to XuanWang-Amos/grpc
that referenced
this pull request
Jun 22, 2023
…rpc#33520) Follow up change of grpc#33222. We don't want file multiple bugs if any of the sub-tests of the `url_map` test fails.
XuanWang-Amos
added a commit
to XuanWang-Amos/grpc
that referenced
this pull request
Jun 22, 2023
…rpc#33520) Follow up change of grpc#33222. We don't want file multiple bugs if any of the sub-tests of the `url_map` test fails.
This was referenced Jun 22, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
XuanWang-Amos
added a commit
that referenced
this pull request
Jun 22, 2023
…(v1.56.x backport) (#33523) Backport of #33520 to v1.56.x. --- Follow up change of #33222. We don't want file multiple bugs if any of the sub-tests of the `url_map` test fails. <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->
XuanWang-Amos
added a commit
that referenced
this pull request
Jun 23, 2023
…(v1.55.x backport) (#33524) Backport of #33520 to v1.55.x. --- Follow up change of #33222. We don't want file multiple bugs if any of the sub-tests of the `url_map` test fails. <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->
veblush
pushed a commit
that referenced
this pull request
Jun 23, 2023
…(v1.48.x backport) (#33531) Backport of #33520 to v1.48.x. --- Follow up change of #33222. We don't want file multiple bugs if any of the sub-tests of the `url_map` test fails. <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->
veblush
pushed a commit
that referenced
this pull request
Jun 23, 2023
…(v1.54.x backport) (#33525) Backport of #33520 to v1.54.x. --- Follow up change of #33222. We don't want file multiple bugs if any of the sub-tests of the `url_map` test fails. <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->
veblush
pushed a commit
that referenced
this pull request
Jun 23, 2023
…(v1.53.x backport) (#33526) Backport of #33520 to v1.53.x. --- Follow up change of #33222. We don't want file multiple bugs if any of the sub-tests of the `url_map` test fails. <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->
veblush
pushed a commit
that referenced
this pull request
Jun 23, 2023
…(v1.52.x backport) (#33527) Backport of #33520 to v1.52.x. --- Follow up change of #33222. We don't want file multiple bugs if any of the sub-tests of the `url_map` test fails. <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->
veblush
pushed a commit
that referenced
this pull request
Jun 23, 2023
…(v1.51.x backport) (#33528) Backport of #33520 to v1.51.x. --- Follow up change of #33222. We don't want file multiple bugs if any of the sub-tests of the `url_map` test fails. <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->
veblush
pushed a commit
that referenced
this pull request
Jun 23, 2023
…(v1.50.x backport) (#33529) Backport of #33520 to v1.50.x. --- Follow up change of #33222. We don't want file multiple bugs if any of the sub-tests of the `url_map` test fails. <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->
veblush
pushed a commit
that referenced
this pull request
Jun 23, 2023
…(v1.49.x backport) (#33530) Backport of #33520 to v1.49.x. --- Follow up change of #33222. We don't want file multiple bugs if any of the sub-tests of the `url_map` test fails. <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->
veblush
pushed a commit
that referenced
this pull request
Jun 23, 2023
…(v1.47.x backport) (#33532) Backport of #33520 to v1.47.x. --- Follow up change of #33222. We don't want file multiple bugs if any of the sub-tests of the `url_map` test fails. <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->
mario-vimal
pushed a commit
to mario-vimal/grpc
that referenced
this pull request
Jul 13, 2023
…rpc#33520) Follow up change of grpc#33222. We don't want file multiple bugs if any of the sub-tests of the `url_map` test fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/psm interop
bloat/none
imported
Specifies if the PR has been imported to the internal repository
per-call-memory/neutral
per-channel-memory/neutral
release notes: no
Indicates if PR should not be in release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We configured TestGrid to file bug separately for each failed sub-target, if we still fail the main target, TestGrid will fail duplicate bugs.
ref b/280934327