[grpclb] Use a separate channel arg to enable load reporting filter #33465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markdroth
added
the
release notes: no
grpc-checks
bot
added
per-call-memory/neutral
per-channel-memory/neutral
bloat/none
labels
apolcyn
approved these changes
Jun 22, 2023
| args_ | ||
| .Set(GRPC_ARG_ADDRESS_IS_BACKEND_FROM_GRPCLB_LOAD_BALANCER, | ||
| is_backend_from_grpclb_load_balancer) | ||
| .Set(GRPC_ARG_GRPCLB_ENABLE_LOAD_REPORTING_FILTER, 1); |
There was a problem hiding this comment.
if is_backend_from_grpclb_load_balancer == false, i.e. if we're using fallback addresses, is it still correct to enable the load reporting filter?
There was a problem hiding this comment.
Arguably no, but that's the existing behavior, so I don't want to change it.
copybara-service
bot
added
the
imported
mario-vimal
pushed a commit
to mario-vimal/grpc
that referenced
this pull request
Jul 13, 2023
…rpc#33465) This avoids overloading the GRPC_ARG_LB_POLICY_NAME channel arg, which is really intended for passing from the application to the client channel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids overloading the GRPC_ARG_LB_POLICY_NAME channel arg, which is really intended for passing from the application to the client channel.