remove skipIf from TypeSmokeTest (issue 7672) #7831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove skipIfStatement from TypeSmokeTest.testCallCredentialsFromPluginUpDown since the test passes on PyPy variants 5.3.0 and newer since these variants have improved compatibility support for the C-Extensions
|
@nathanielmanistaatgoogle Take a look and add necessary labels. Technically this can go in before the #7763 since we still haven't enabled PyPy testing. |
|
Luhguhtum! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove skipIfStatement from
TypeSmokeTest.testCallCredentialsFromPluginUpDown since the test passes
on PyPy variants 5.3.0 and newer since these variants have improved
compatibility support for the C-Extensions.
To be merged after Add PyPy 5.3.1 to dockerfile and template