Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial fixes for xml report generation. #198

Merged
merged 1 commit into from
Jul 14, 2021
Merged

Initial fixes for xml report generation. #198

merged 1 commit into from
Jul 14, 2021

Conversation

paulosjca
Copy link
Collaborator

  • Count errors instead of failures.
  • Stop counting warnings as errors.
  • Keep id attribute but only for testsuite, as a count starting from zero.
  • Rename package to xunit.

@paulosjca
Initial fixes for xml report generation.
e81bde3 
* Count errors instead of failures.
* Stop counting warnings as errors.
* Keep `id` attribute but only for `testsuite`, as a count starting from zero.
* Rename package to `xunit`.
@paulosjca paulosjca added the release notes: yes Indicates that PR needs to be in release notes label Jul 12, 2021
@paulosjca paulosjca self-assigned this Jul 12, 2021
wanlin31
wanlin31 approved these changes Jul 13, 2021
View reviewed changes
Copy link
Collaborator

@wanlin31 wanlin31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have a quick question regarding ID, is it the same with the LoadTest's name?

@paulosjca
Copy link
Collaborator Author

LGTM. I have a quick question regarding ID, is it the same with the LoadTest's name?

Strictly speaking, this field is not necessarily, because it is not part of the format that is understood by kokoro. The only reason to include it at all is because it is part of the Junit schema:

https://github.com/windyroad/JUnit-Schema/blob/master/JUnit.xsd

What we were doing before is add id to testsuites, testsuite and testcase, and to fill it with something derived from the element's name. However, if you look at the Junit schema, it includes id only for testsuite, where it is a counter (0, 1, 2,...). This PR changes the id attribute to follow the Junit schema. In the future we may consider whether we should include it or not.

@paulosjca paulosjca merged commit bbef209 into grpc:master Jul 14, 2021
@paulosjca paulosjca deleted the nosync branch July 14, 2021 01:23
ybbbby pushed a commit to ybbbby/test-infra that referenced this pull request Jul 28, 2021
@paulosjca @ybbbby
Initial fixes for xml report generation. (grpc#198)
c7e3b23 
* Count errors instead of failures.
* Stop counting warnings as errors.
* Keep `id` attribute but only for `testsuite`, as a count starting from zero.
* Rename package to `xunit`.
ybbbby added a commit that referenced this pull request Jul 29, 2021
@ybbbby @wanlin31 @paulosjca
Synchronize kubebuilder3 branch with master. (#203)
392ba57 
* Update defatuls_template.yaml for php7 (#186)

* Update example tests to include named drivers. (#189)

Examples are generated from grpc/grpc#26501.

* Add timeout for workers (#182)

This commit adds timeout for workers. Due to the complication of
directly pass the command and argument through LoadTest
configuration yaml files, a script is need to start the worker
with timeout. To make the script work, the argument
--driver_port of the run container has to be exposed. Currently
--driver_port is set as an environmental variable and passed to
worker at starting time. The templates are also updated to reflect
the change.

* Fix executable path in Java Loadtest example with prebuilt image (#190)

* Add governance and maintainers files. (#191)

* Update driver timeout (#192)

This commit update where the timeout is applied for driver
process. The timeout was wrapped around the driver
process only, which left other operations such as uploading
results to BigQuery unguarded. The timeout is updated
to wrap around the whole operations to make sure driver
pod will timeout after given time.

* Update README files to include test runner. (#194)

* Update tools README to include test runner.

* Move tool binaries under the tools directory. (#196)

* Feature/add php7_protobuf_c (#195)

The PR wraps timeout on the whole operation of php7 worker. 
Also add support php7_protobuf_c tests.

* Initial fixes for xml report generation. (#198)

* Count errors instead of failures.
* Stop counting warnings as errors.
* Keep `id` attribute but only for `testsuite`, as a count starting from zero.
* Rename package to `xunit`.

* Remove unneeded copy from xml report generation. (#200)

* Ignore empty default pool (#201)

* ignore empty default pool

* error our when default pool is used but undefined

* prettier code

Co-authored-by: Wanlin Du <67486458+wanlin31@users.noreply.github.com>
Co-authored-by: Paulo Castello da Costa <6579971+paulosjca@users.noreply.github.com>
ybbbby added a commit that referenced this pull request Aug 3, 2021
@ybbbby @wanlin31 @paulosjca
merge master to kubebuilder3 to solve conflicts. (#207)
ae4dc11 
* Update defatuls_template.yaml for php7 (#186)

* Update example tests to include named drivers. (#189)

Examples are generated from grpc/grpc#26501.

* Add timeout for workers (#182)

This commit adds timeout for workers. Due to the complication of
directly pass the command and argument through LoadTest
configuration yaml files, a script is need to start the worker
with timeout. To make the script work, the argument
--driver_port of the run container has to be exposed. Currently
--driver_port is set as an environmental variable and passed to
worker at starting time. The templates are also updated to reflect
the change.

* Fix executable path in Java Loadtest example with prebuilt image (#190)

* Add governance and maintainers files. (#191)

* Update driver timeout (#192)

This commit update where the timeout is applied for driver
process. The timeout was wrapped around the driver
process only, which left other operations such as uploading
results to BigQuery unguarded. The timeout is updated
to wrap around the whole operations to make sure driver
pod will timeout after given time.

* Update README files to include test runner. (#194)

* Update tools README to include test runner.

* Move tool binaries under the tools directory. (#196)

* Feature/add php7_protobuf_c (#195)

The PR wraps timeout on the whole operation of php7 worker. 
Also add support php7_protobuf_c tests.

* change gpg keyserver name (#197)

* Initial fixes for xml report generation. (#198)

* Count errors instead of failures.
* Stop counting warnings as errors.
* Keep `id` attribute but only for `testsuite`, as a count starting from zero.
* Rename package to `xunit`.

* Remove unneeded copy from xml report generation. (#200)

* ignore empty default pool

* error our when default pool is used but undefined

* prettier code

* Ignore empty default pool (#201)

* ignore empty default pool

* error our when default pool is used but undefined

* prettier code

* Separate deployment of cleanup agent from main process (#202)

This pr separate the deploying cleanup agent from the main deploy process.
This is because the cleanup agent is no longer necessary in terms of killing
the leftover pods.

* Delete all cleanup agent codes (#204)

* Separate deployment of cleanup agent from main process (#202)

This pr separate the deploying cleanup agent from the main deploy process.
This is because the cleanup agent is no longer necessary in terms of killing
the leftover pods.

* solve conflict

* Delete all cleanup agent codes (#204)

* resolve conflict

* prettier style

* prettier style

Co-authored-by: Wanlin Du <67486458+wanlin31@users.noreply.github.com>
Co-authored-by: Paulo Castello da Costa <6579971+paulosjca@users.noreply.github.com>
ybbbby added a commit that referenced this pull request Aug 3, 2021
@ybbbby @codeblooded
@wanlin31 @paulosjca
Merge kubebuilder3 to master. (#209)
20a0baf 
* ignore empty default pool

* error our when default pool is used but undefined

* prettier code

* Upgrade to kubebuilder 3 (#187)

This change upgrades the project to use Kubebuilder 3 and newer
Kubernetes APIs. For details of all the included changes, please refer
to the Kubebuilder migration docs:

  https://book.kubebuilder.io/migration/v2vsv3.html

* resolve php7 build error, add leases access to controller

* Synchronize `kubebuilder3` branch with master. (#203)

* Update defatuls_template.yaml for php7 (#186)

* Update example tests to include named drivers. (#189)

Examples are generated from grpc/grpc#26501.

* Add timeout for workers (#182)

This commit adds timeout for workers. Due to the complication of
directly pass the command and argument through LoadTest
configuration yaml files, a script is need to start the worker
with timeout. To make the script work, the argument
--driver_port of the run container has to be exposed. Currently
--driver_port is set as an environmental variable and passed to
worker at starting time. The templates are also updated to reflect
the change.

* Fix executable path in Java Loadtest example with prebuilt image (#190)

* Add governance and maintainers files. (#191)

* Update driver timeout (#192)

This commit update where the timeout is applied for driver
process. The timeout was wrapped around the driver
process only, which left other operations such as uploading
results to BigQuery unguarded. The timeout is updated
to wrap around the whole operations to make sure driver
pod will timeout after given time.

* Update README files to include test runner. (#194)

* Update tools README to include test runner.

* Move tool binaries under the tools directory. (#196)

* Feature/add php7_protobuf_c (#195)

The PR wraps timeout on the whole operation of php7 worker. 
Also add support php7_protobuf_c tests.

* Initial fixes for xml report generation. (#198)

* Count errors instead of failures.
* Stop counting warnings as errors.
* Keep `id` attribute but only for `testsuite`, as a count starting from zero.
* Rename package to `xunit`.

* Remove unneeded copy from xml report generation. (#200)

* Ignore empty default pool (#201)

* ignore empty default pool

* error our when default pool is used but undefined

* prettier code

Co-authored-by: Wanlin Du <67486458+wanlin31@users.noreply.github.com>
Co-authored-by: Paulo Castello da Costa <6579971+paulosjca@users.noreply.github.com>

* Solve flakiness (#205)

* Separate deployment of cleanup agent from main process (#202)

This pr separate the deploying cleanup agent from the main deploy process.
This is because the cleanup agent is no longer necessary in terms of killing
the leftover pods.

* solve conflict

* Delete all cleanup agent codes (#204)

* resolve conflict

* Synchronize kubebuilder3 branch with master. (#206)

* Separate deployment of cleanup agent from main process (#202)

This pr separate the deploying cleanup agent from the main deploy process.
This is because the cleanup agent is no longer necessary in terms of killing
the leftover pods.

* solve conflict

* Delete all cleanup agent codes (#204)

* resolve conflict

Co-authored-by: Wanlin Du <67486458+wanlin31@users.noreply.github.com>

* prettier style

* prettier style

* merge master to kubebuilder3 to solve conflicts. (#207)

* Update defatuls_template.yaml for php7 (#186)

* Update example tests to include named drivers. (#189)

Examples are generated from grpc/grpc#26501.

* Add timeout for workers (#182)

This commit adds timeout for workers. Due to the complication of
directly pass the command and argument through LoadTest
configuration yaml files, a script is need to start the worker
with timeout. To make the script work, the argument
--driver_port of the run container has to be exposed. Currently
--driver_port is set as an environmental variable and passed to
worker at starting time. The templates are also updated to reflect
the change.

* Fix executable path in Java Loadtest example with prebuilt image (#190)

* Add governance and maintainers files. (#191)

* Update driver timeout (#192)

This commit update where the timeout is applied for driver
process. The timeout was wrapped around the driver
process only, which left other operations such as uploading
results to BigQuery unguarded. The timeout is updated
to wrap around the whole operations to make sure driver
pod will timeout after given time.

* Update README files to include test runner. (#194)

* Update tools README to include test runner.

* Move tool binaries under the tools directory. (#196)

* Feature/add php7_protobuf_c (#195)

The PR wraps timeout on the whole operation of php7 worker. 
Also add support php7_protobuf_c tests.

* change gpg keyserver name (#197)

* Initial fixes for xml report generation. (#198)

* Count errors instead of failures.
* Stop counting warnings as errors.
* Keep `id` attribute but only for `testsuite`, as a count starting from zero.
* Rename package to `xunit`.

* Remove unneeded copy from xml report generation. (#200)

* ignore empty default pool

* error our when default pool is used but undefined

* prettier code

* Ignore empty default pool (#201)

* ignore empty default pool

* error our when default pool is used but undefined

* prettier code

* Separate deployment of cleanup agent from main process (#202)

This pr separate the deploying cleanup agent from the main deploy process.
This is because the cleanup agent is no longer necessary in terms of killing
the leftover pods.

* Delete all cleanup agent codes (#204)

* Separate deployment of cleanup agent from main process (#202)

This pr separate the deploying cleanup agent from the main deploy process.
This is because the cleanup agent is no longer necessary in terms of killing
the leftover pods.

* solve conflict

* Delete all cleanup agent codes (#204)

* resolve conflict

* prettier style

* prettier style

Co-authored-by: Wanlin Du <67486458+wanlin31@users.noreply.github.com>
Co-authored-by: Paulo Castello da Costa <6579971+paulosjca@users.noreply.github.com>

Co-authored-by: Ben Reed <benreed@google.com>
Co-authored-by: Wanlin Du <67486458+wanlin31@users.noreply.github.com>
Co-authored-by: Paulo Castello da Costa <6579971+paulosjca@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanlin31 wanlin31 wanlin31 approved these changes

@ybbbby ybbbby Awaiting requested review from ybbbby

Assignees

@paulosjca paulosjca

Labels
release notes: yes Indicates that PR needs to be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulosjca @wanlin31