Start kubebuilder 3 upgrade in development branch #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeblooded
force-pushed
the
upgrade-kubebuilder
branch
6 times, most recently
from
8a3e3f0
to
083a7f9
Compare
codeblooded
force-pushed
the
upgrade-kubebuilder
branch
7 times, most recently
from
69086b3
to
a48486c
Compare
codeblooded
force-pushed
the
upgrade-kubebuilder
branch
from
a48486c
to
2026271
Compare
This change upgrades the project to use Kubebuilder 3 and newer Kubernetes APIs. For details of all the included changes, please refer to the Kubebuilder migration docs: https://book.kubebuilder.io/migration/v2vsv3.html
codeblooded
force-pushed
the
upgrade-kubebuilder
branch
from
2026271
to
99432af
Compare
|
It is working with a local debugger. It was hanging a bit on my test deployment, so I will try again. I noticed additional changes have been made on master since this was authored. I'm not going to try to rebase, since this is so large. I will just do some merges. Anyway, I'm opening it up for review. You all can begin poking around ;) |
|
There appears to be a permissions issue blocking the controller in the test-infra-system namespace from accessing pods in the default namespace. I have to do some digging to try to figure out why... but I only anticipate RBAC changes... so I'm leaving this open for comments. |
codeblooded
changed the title
codeblooded
changed the title
|
Thanks! I assume it could be mergeded? |
ybbbby
approved these changes
Jul 26, 2021
ybbbby
reviewed
Jul 26, 2021
| @@ -29,48 +31,50 @@ type loadTestV1Getter struct { | |||
| client rest.Interface | |||
| } | |||
|
|
|||
| func (l *loadTestV1Getter) Create(test *grpcv1.LoadTest, opts metav1.CreateOptions) (*grpcv1.LoadTest, error) { | |||
| var _ LoadTestGetter = &loadTestV1Getter{} | |||
ybbbby
reviewed
Jul 26, 2021
| @@ -25,11 +25,37 @@ spec: | |||
| nodeSelector: | |||
| default-system-pool: "true" | |||
| containers: | |||
| # securityContext: | |||
| # runAsNonRoot: true | |||
| containers: | |||
ybbbby
added a commit
that referenced
this pull request
Aug 3, 2021
* ignore empty default pool * error our when default pool is used but undefined * prettier code * Upgrade to kubebuilder 3 (#187) This change upgrades the project to use Kubebuilder 3 and newer Kubernetes APIs. For details of all the included changes, please refer to the Kubebuilder migration docs: https://book.kubebuilder.io/migration/v2vsv3.html * resolve php7 build error, add leases access to controller * Synchronize `kubebuilder3` branch with master. (#203) * Update defatuls_template.yaml for php7 (#186) * Update example tests to include named drivers. (#189) Examples are generated from grpc/grpc#26501. * Add timeout for workers (#182) This commit adds timeout for workers. Due to the complication of directly pass the command and argument through LoadTest configuration yaml files, a script is need to start the worker with timeout. To make the script work, the argument --driver_port of the run container has to be exposed. Currently --driver_port is set as an environmental variable and passed to worker at starting time. The templates are also updated to reflect the change. * Fix executable path in Java Loadtest example with prebuilt image (#190) * Add governance and maintainers files. (#191) * Update driver timeout (#192) This commit update where the timeout is applied for driver process. The timeout was wrapped around the driver process only, which left other operations such as uploading results to BigQuery unguarded. The timeout is updated to wrap around the whole operations to make sure driver pod will timeout after given time. * Update README files to include test runner. (#194) * Update tools README to include test runner. * Move tool binaries under the tools directory. (#196) * Feature/add php7_protobuf_c (#195) The PR wraps timeout on the whole operation of php7 worker. Also add support php7_protobuf_c tests. * Initial fixes for xml report generation. (#198) * Count errors instead of failures. * Stop counting warnings as errors. * Keep `id` attribute but only for `testsuite`, as a count starting from zero. * Rename package to `xunit`. * Remove unneeded copy from xml report generation. (#200) * Ignore empty default pool (#201) * ignore empty default pool * error our when default pool is used but undefined * prettier code Co-authored-by: Wanlin Du <67486458+wanlin31@users.noreply.github.com> Co-authored-by: Paulo Castello da Costa <6579971+paulosjca@users.noreply.github.com> * Solve flakiness (#205) * Separate deployment of cleanup agent from main process (#202) This pr separate the deploying cleanup agent from the main deploy process. This is because the cleanup agent is no longer necessary in terms of killing the leftover pods. * solve conflict * Delete all cleanup agent codes (#204) * resolve conflict * Synchronize kubebuilder3 branch with master. (#206) * Separate deployment of cleanup agent from main process (#202) This pr separate the deploying cleanup agent from the main deploy process. This is because the cleanup agent is no longer necessary in terms of killing the leftover pods. * solve conflict * Delete all cleanup agent codes (#204) * resolve conflict Co-authored-by: Wanlin Du <67486458+wanlin31@users.noreply.github.com> * prettier style * prettier style * merge master to kubebuilder3 to solve conflicts. (#207) * Update defatuls_template.yaml for php7 (#186) * Update example tests to include named drivers. (#189) Examples are generated from grpc/grpc#26501. * Add timeout for workers (#182) This commit adds timeout for workers. Due to the complication of directly pass the command and argument through LoadTest configuration yaml files, a script is need to start the worker with timeout. To make the script work, the argument --driver_port of the run container has to be exposed. Currently --driver_port is set as an environmental variable and passed to worker at starting time. The templates are also updated to reflect the change. * Fix executable path in Java Loadtest example with prebuilt image (#190) * Add governance and maintainers files. (#191) * Update driver timeout (#192) This commit update where the timeout is applied for driver process. The timeout was wrapped around the driver process only, which left other operations such as uploading results to BigQuery unguarded. The timeout is updated to wrap around the whole operations to make sure driver pod will timeout after given time. * Update README files to include test runner. (#194) * Update tools README to include test runner. * Move tool binaries under the tools directory. (#196) * Feature/add php7_protobuf_c (#195) The PR wraps timeout on the whole operation of php7 worker. Also add support php7_protobuf_c tests. * change gpg keyserver name (#197) * Initial fixes for xml report generation. (#198) * Count errors instead of failures. * Stop counting warnings as errors. * Keep `id` attribute but only for `testsuite`, as a count starting from zero. * Rename package to `xunit`. * Remove unneeded copy from xml report generation. (#200) * ignore empty default pool * error our when default pool is used but undefined * prettier code * Ignore empty default pool (#201) * ignore empty default pool * error our when default pool is used but undefined * prettier code * Separate deployment of cleanup agent from main process (#202) This pr separate the deploying cleanup agent from the main deploy process. This is because the cleanup agent is no longer necessary in terms of killing the leftover pods. * Delete all cleanup agent codes (#204) * Separate deployment of cleanup agent from main process (#202) This pr separate the deploying cleanup agent from the main deploy process. This is because the cleanup agent is no longer necessary in terms of killing the leftover pods. * solve conflict * Delete all cleanup agent codes (#204) * resolve conflict * prettier style * prettier style Co-authored-by: Wanlin Du <67486458+wanlin31@users.noreply.github.com> Co-authored-by: Paulo Castello da Costa <6579971+paulosjca@users.noreply.github.com> Co-authored-by: Ben Reed <benreed@google.com> Co-authored-by: Wanlin Du <67486458+wanlin31@users.noreply.github.com> Co-authored-by: Paulo Castello da Costa <6579971+paulosjca@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change upgrades the project to use Kubebuilder 3 and newer Kubernetes APIs. For details of all the included changes, please refer to the Kubebuilder migration docs: https://book.kubebuilder.io/migration/v2vsv3.html
Note this PR will merge into the kubebuilder3 branch and it is not yet deployable.