node 5.7.0 – Warning: Cannot delete files outside the current working directory.

[m99coder]

Hi guys,

I’m experiencing an issue with the new node 5.7.0.

// Gruntfile.js
grunt.initConfig({
    clean: {
        test: {
            src: ['coverage']
        }
    }
});

$ grunt test:clean --verbose
/* ... */
Running "clean:test" (clean) task
Verifying property clean.test exists in config...OK
Files: coverage
Options: force=false, no-write=false
ERROR
Warning: Cannot delete files outside the current working directory. Use --force to continue.

$ node -v && npm -v
v5.7.0
3.7.3

It work fine before the node update and I don’t get why the given coverage directory should be outside of working directory. Gruntfile.js and coverage directory are at the same level. The exact same level I’m calling grunt test:clean in.

If you need further more verbose output let me know.

[timvancleef]

Having the same issue.
There seems to be a change in nodejs' path.relative() function.
With Node v4.3.1 path.relative('a/b/c', 'a/b') returns ..
Whereas with Node v5.7.0 it returns ../c.
Therefore the isPathInCwd check in the clean task itself fails.

[mscdex]

@timvancleef For me node -pe "require('path').relative('a/b/c', 'a/b')" on node v5.7.0 outputs ../../b and not ../c.

[timvancleef]

@mscdex oh you are right.
Noetheless the important/problematic part is the b, because isPathInCwd checks for word characters (/w+/).

[shama]

Related failing test: https://travis-ci.org/gruntjs/grunt-contrib-clean/jobs/110697189 Nice research you all :)

[spdaly]

+1

[shian48263]

+1 on OS X El Capitan.

Is it save to add options: {force: true} for the moment before node v5.7.1 is released?

[shama]

If you want safety, I recommend going with Node v4.3.1 until a fix is released.

[roryhardy]

For what it's worth, I haven't observed this issue with versions of Node prior to 5.7.0 (on 5.6.0 currently).

[vbarbarosh]

Have the same issue.

$ node --version
v5.7.0
$ node -pe 'require("path").relative("/aa/bb/cc/dd", "/aa/bb/cc")'
../../cc

$ node --version
v5.0.0
$ node -pe 'require("path").relative("/aa/bb/cc/dd", "/aa/bb/cc")'
..

[m99coder]

The node team already fixed it with this commit nodejs/node@3a331b6

[XhmikosR]

Node.js 5.7.1 is out with the relevant fixes.

[ctrlmaniac]

Hmm same problem here:

$ node --version
v8.9.4
$ npm --version
6.2.0