feat(#195): adopt koin annotation for dependency injection #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👀🔎 |
kcw-grunt
requested changes
Aug 16, 2025
| @@ -0,0 +1,63 @@ | |||
| package com.brainwallet.data.repository | |||
There was a problem hiding this comment.
is this to close? https://github.com/gruntsoftware/internal/issues/155 @JosephSanjaya
There was a problem hiding this comment.
yes im already done for the remote config, but currently there's no key that use the source yet
There was a problem hiding this comment.
on it to fix
|
@JosephSanjaya Here are my notes |
JosephSanjaya
force-pushed
the
js/feat/#195-koin-annotations
branch
from
0c9fc8c to
314e401
Compare
fix the issue can you recheck the PR?
|
Let's see a new PR from your clone @JosephSanjaya to make sure the Checks are triggered |
|
Closing as we merged the cloned PR @JosephSanjaya |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We try to add some basic guidance here.
Here is a great examples from the past @JosephSanjaya :
#89
#86