chore(#234): normalize Indonesian language code to "id" #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Indonesian language code "in" is normalized to "id" in `MessagingTopicDataSource` to align with the ISO 639-1 standard used by the backend. This ensures consistency in topic generation for Indonesian language users. Tests have been added to verify this normalization for both "in" and "in_ID" inputs.
JosephSanjaya
force-pushed
the
js/chore/#234-topic-normalization
branch
from
fbcc782 to
22125fd
Compare
|
rebased |
kcw-grunt
approved these changes
Aug 30, 2025
| } ?: defaultLanguage | ||
|
|
||
| return targetLanguage.code.split("-").first().lowercase() | ||
| val baseCode = targetLanguage.code.split("-").first().lowercase() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📱 Description
The Indonesian language code "in" is normalized to "id" in
MessagingTopicDataSourceto align with the ISO 639-1 standard used by the backend.This ensures consistency in topic generation for Indonesian language users. Tests have been added to verify this normalization for both "in" and "in_ID" inputs.
Platform
🎯 Type of Change
📋 Changes
id🔗 Related Issues
🧪 Tests Status
idnotin📸 Screenshots/Videos
N/A Behavior is not changing on front side
🎯 Reviewers
@kcw-grunt, @josikie