Skip to content

Conversation

kcw-grunt
Copy link
Collaborator

@kcw-grunt kcw-grunt commented Mar 3, 2025

Overview

Small branding and UI polishes

Release Notes

  • Updated logos
  • Code bump

@kcw-grunt kcw-grunt self-assigned this Mar 3, 2025
Language.BLANK.code,
Language.BLANK.title,
" ",
R.raw.english,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it we are using raw resource, that's why previously I propose to remove the asset pack

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. This was both to learn about PAD...We want to keep the .aab smaller.
I would rather remove the raw assets....will change

@kcw-grunt kcw-grunt marked this pull request as ready for review March 3, 2025 23:23
chore: refactor dependency injection using koin
- added test analytics for skip
- update the localizations order test
@kcw-grunt
Copy link
Collaborator Author

What are your thoughts on the audio files @andhikayuana ?

@andhikayuana
Copy link
Contributor

What are your thoughts on the audio files @andhikayuana ?

will working on it this week, also change to the slide up/down when the user need to change language

@kcw-grunt
Copy link
Collaborator Author

Currently the files are not playing @andhikayuana we can address as a tech debt soon.

@kcw-grunt kcw-grunt merged commit 5f7f004 into main Mar 24, 2025
@kcw-grunt kcw-grunt deleted the release/v4.3.1 branch April 19, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants