Skip to content

fix: race condition when clear shared prefs values after wipeAll #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2025
Merged

fix: race condition when clear shared prefs values after wipeAll #62

merged 1 commit into from
Apr 16, 2025

Conversation

andhikayuana
Copy link
Contributor

Overview

fix race condition when execute wipeAll the shared preferences should be cleared properly first before we add new values e.g. phraseWritten

@andhikayuana andhikayuana self-assigned this Apr 16, 2025
kcw-grunt
kcw-grunt approved these changes Apr 16, 2025
View reviewed changes
Copy link
Collaborator

@kcw-grunt kcw-grunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kcw-grunt kcw-grunt merged commit 51a4d9a into develop Apr 16, 2025
1 check failed
@kcw-grunt kcw-grunt deleted the hotfix/prefs-race-condition branch April 25, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcw-grunt kcw-grunt kcw-grunt approved these changes

@josikie josikie Awaiting requested review from josikie

Assignees

@andhikayuana andhikayuana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andhikayuana @kcw-grunt