Skip to content

Add function to fill out template strings in files #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 26, 2018
Merged

Add function to fill out template strings in files #10

merged 4 commits into from
Oct 26, 2018

Conversation

tonerdo
Copy link
Contributor

@tonerdo tonerdo commented Oct 25, 2018

This PR implements a common need we encounter in our run-* modules to fill out template strings in configuration files with a specified value.

brikis98
brikis98 approved these changes Oct 26, 2018
View reviewed changes
Copy link
Member

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition. Add a test case for multiple placeholders and ship it!

@tonerdo tonerdo merged commit 298eefa into master Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brikis98 brikis98 brikis98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tonerdo @brikis98